Repository navigation
[%pS migration] Use %pS in ext/spl/* - #23146
Merged
DanielEScherzer merged 6 commits intoOct 24, 2026
Merged
Conversation
Girgias
requested changes
Aug 9, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Please don't blanket apply this change.
Comment on lines
1311
to
1325
| spl_filesystem_object *intern = spl_filesystem_from_obj(Z_OBJ_P(ZEND_THIS)); | ||
| zend_class_entry *ce = NULL; | ||
| zend_string *path; | ||
|
|
||
| if (zend_parse_parameters(ZEND_NUM_ARGS(), "|C!", &ce) == FAILURE) { | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (ce == NULL) { | ||
| ce = intern->info_class; | ||
| } else if (!instanceof_function(ce, spl_ce_SplFileInfo)) { | ||
| zend_argument_type_error(1, "must be a class name derived from %s or null, %s given", ZSTR_VAL(spl_ce_SplFileInfo->name), ZSTR_VAL(ce->name)); | ||
| zend_argument_type_error(1, "must be a class name derived from %pS or null, %pS given", spl_ce_SplFileInfo->name, ce->name); | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This code is actually just bad. Set ce to spl_ce_SplFileInfo and then ZPP will take care of this.
DanielEScherzer
force-pushed
the
ps-migration-ext-spl
branch
from
October 3, 2026 19:23
92b0ff3 to
d5b9868
Compare
DanielEScherzer
force-pushed
the
ps-migration-ext-spl
branch
from
October 5, 2026 00:05
d5b9868 to
3d3fca6
Compare
Girgias
approved these changes
Oct 24, 2026
DanielEScherzer
force-pushed
the
ps-migration-ext-spl
branch
from
October 24, 2026 02:38
3d3fca6 to
0e63b7a
Compare
DanielEScherzer
marked this pull request as ready for review
October 24, 2026 02:42
Member
Author
|
Not going to wait for the still-queued macos tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.